Skip to content

Comments

llvmPackages_git.mlir: init#290767

Merged
wegank merged 1 commit intoNixOS:masterfrom
wegank:mlir-git
Feb 24, 2024
Merged

llvmPackages_git.mlir: init#290767
wegank merged 1 commit intoNixOS:masterfrom
wegank:mlir-git

Conversation

@wegank
Copy link
Member

@wegank wegank commented Feb 23, 2024

Description of changes

#280572 (comment)

There were also comments not addressed but marked as resolved in that PR. I've unresolved them and will create a separate PR to fix them, if no one gets ahead of me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank
Copy link
Member Author

wegank commented Feb 23, 2024

@ofborg build llvmPackages_git.mlir

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 23, 2024
@wegank wegank merged commit a426b50 into NixOS:master Feb 24, 2024
@wegank wegank deleted the mlir-git branch February 24, 2024 03:48
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions
Copy link
Contributor

Git push to origin failed for release-23.11 with exitcode 1

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
@github-actions
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-290767-to-release-23.11 origin/release-23.11
cd .worktree/backport-290767-to-release-23.11
git switch --create backport-290767-to-release-23.11
git cherry-pick -x 276b313a2b80f47e5c665717f0ac47e2457d5b24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants